Update requests lib for mend #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikayla Thompson <[email protected]>
mikaylathompson
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
okhasawn,
peternied and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
============================================
+ Coverage 63.21% 63.32% +0.10%
- Complexity 1566 1569 +3
============================================
Files 218 218
Lines 8820 8820
Branches 773 773
============================================
+ Hits 5576 5585 +9
+ Misses 2838 2831 -7
+ Partials 406 404 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peternied
approved these changes
Jun 7, 2024
|
Thanks - not sure that mend picked this up ;/ I would have expected to see something like 'N issues have been fixed` in the mend results. But I'd rather move forward that try to understand what mend is processing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mend is concerned about Requests 2.31.0. I suspect we're not actually using it because our definition is >= 2.31, but obviously it's necessary to guarantee that.
Issues Resolved
#670
This issue is also on the security dashboard, so we get a two-for-one.
Testing
One is a testing requirement, so it's tested via our tests. Ran unit tests for fetch.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.